Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Use Scala 3.3.1 for integration tests #3311

Merged
merged 5 commits into from
Dec 19, 2023
Merged

internal: Use Scala 3.3.1 for integration tests #3311

merged 5 commits into from
Dec 19, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Dec 19, 2023

@xerial xerial changed the title Upgrade to Scala 3.3.2 [do not merge] Test Upgrade to Scala 3.3.2-RC1 Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09287a3) 82.71% compared to head (408ad0a) 82.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3311      +/-   ##
==========================================
- Coverage   82.71%   82.70%   -0.01%     
==========================================
  Files         355      355              
  Lines       14836    14836              
  Branches     2510     2510              
==========================================
- Hits        12271    12270       -1     
- Misses       2565     2566       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09287a3...408ad0a. Read the comment docs.

@xerial
Copy link
Member Author

xerial commented Dec 19, 2023

Error:  2023-12-19 21:48:35.218Z  info [AirframeHttpPlugin] Extracting airframe-http 23.12.1-5-ccf50e28-SNAPSHOT package to /tmp/sbt_b0a8a5c4/server/target/scala-3/airframe/23.12.1-5-ccf50e28-SNAPSHOT/local  - (AirframeHttpPlugin.scala:152)
[info] [info] compiling 2 Scala sources to /tmp/sbt_b0a8a5c4/spi/target/scala-3.3.0/classes ...
[info] [error] error while loading package,
[info] [error] class file wvlet/airframe/package.class is broken, reading aborted with class java.util.NoSuchElementException
[info] [error] contextual$
[info] [error] one error found
[info] [error] (spi / Compile / compileIncremental) Compilation failed
[info] [error] Total time: 5 s, completed Dec 19, 2023, 9:48:39 PM
Error:  x sbt-airframe/generate-client 

@xerial xerial changed the title [do not merge] Test Upgrade to Scala 3.3.2-RC1 internal: Use Scala 3.3.1 for integration tests Dec 19, 2023
@xerial
Copy link
Member Author

xerial commented Dec 19, 2023

No major problem has found for using Scala 3.3.2-RC1

@xerial xerial closed this Dec 19, 2023
@xerial xerial reopened this Dec 19, 2023
@xerial xerial enabled auto-merge (squash) December 19, 2023 22:40
@github-actions github-actions bot added internal Internal changes (usually non-user facing) labels Dec 19, 2023
@xerial xerial merged commit 49d31ba into main Dec 19, 2023
32 checks passed
@xerial xerial deleted the scala-3.3.2 branch December 19, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes (usually non-user facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant