Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

surface (fix): Fixes #3353 in building surfaces of classes with type params in Scala3 #3405

Merged
merged 2 commits into from
Feb 25, 2024
Merged

surface (fix): Fixes #3353 in building surfaces of classes with type params in Scala3 #3405

merged 2 commits into from
Feb 25, 2024

Conversation

xerial
Copy link
Member

@xerial xerial commented Feb 25, 2024

No description provided.

@github-actions github-actions bot added the bug label Feb 25, 2024
@xerial
Copy link
Member Author

xerial commented Feb 25, 2024 

[error] /Users/leo/work/git/airframe/airframe-surface/src/test/scala/wvlet/airframe/surface/i3363.scala:24:7: macro has not been expanded
[error]   test("With an optional value default argument") {
[error]       ^

The newly added test cases fail in Scala 2 with the above error. It needs to be fixed, but less prioritized for now.

@xerial xerial enabled auto-merge (squash) February 25, 2024 06:56
@xerial xerial merged commit a2c69a1 into main Feb 25, 2024
15 checks passed
@xerial xerial deleted the option-default-value branch February 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xerial