Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @for instead of @while for WVU Slash positition modifier classes #274

Closed
adamjohnson opened this issue Jul 16, 2020 · 0 comments · Fixed by #275
Closed

Use @for instead of @while for WVU Slash positition modifier classes #274

adamjohnson opened this issue Jul 16, 2020 · 0 comments · Fixed by #275
Assignees
Labels
enhancement New feature or request

Comments

@adamjohnson
Copy link
Contributor

As mentioned in a comment in #273, the @while loop used in _wvu-slash.scss breaks gulp-dart-sass/gulp-sass with the Dart Sass compiler.

Current code:

Lines 76-78 and 100 of _wvu-slash.scss.

$i: 1;
@while $i < 5 {
  .wvu-slash { ... }
  $i: $i + 1;
}

I have a feeling this is due to either calc(-25% - (#{$i} * #{$spacer})) or ($i * $spacer).

The fix:

@for $i from 1 through 5 {
  .wvu-slash { ... }
}
@adamjohnson adamjohnson added the enhancement New feature or request label Jul 16, 2020
@adamjohnson adamjohnson self-assigned this Jul 16, 2020
adamjohnson added a commit that referenced this issue Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant