Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoughts @AroneyS ? Tests pass on my machine, something is wrong with the CI atm. It basically just runs strobealign --aemb, but can output dense or sparse, takes multiple refs and readsets etc, so a little more ergonomic.
Still needs to make a cached strobealign index if there are multiple readsets for a single reference. Also seems like it wouldn't be hard to adjust to
genome
mode too, just by taking a length-weighted average of the means it predicts.Unfortunately it can't be used as a drop-in replacement for binning, because it only reports mean, not variance.
Once this is through, can copy the template so we can use fairy as well (apparently using it as an API isn't well supported).
ben