Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove invalid options argument #1048

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix!: Remove invalid options argument #1048

merged 2 commits into from
Oct 4, 2024

Conversation

aklinker1
Copy link
Collaborator

Remove the final options argument after the substitutions array. It's documentation without Chrome was minimal, and Firefox errored out when passing it to browser.i18n.getMessage.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit cb147f4
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6700749d32d224000877ce39
😎 Deploy Preview https://deploy-preview-1048--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 marked this pull request as ready for review October 4, 2024 22:59
Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1048

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1048

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1048

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1048

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1048

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1048

wxt

pnpm add https://pkg.pr.new/wxt@1048

commit: cb147f4

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (539d482) to head (cb147f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
+ Coverage   81.82%   82.10%   +0.28%     
==========================================
  Files         127      127              
  Lines        6634     6634              
  Branches     1102     1104       +2     
==========================================
+ Hits         5428     5447      +19     
+ Misses       1192     1173      -19     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 6c60872 into main Oct 4, 2024
18 checks passed
@aklinker1 aklinker1 deleted the i18n-remove-options branch October 4, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant