-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support registration: "runtime"
for MV2
#1431
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@wxt-dev/auto-icons
@wxt-dev/module-solid
@wxt-dev/i18n
@wxt-dev/module-svelte
@wxt-dev/module-react
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
wxt
commit: |
@harmonyharmo We'll need to fix the failing tests, but in the meantime, can you try this out in your project? You can install your PR via: npm i https://pkg.pr.new/wxt@1431 |
5af0fb2
to
397d923
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
==========================================
- Coverage 81.34% 81.05% -0.30%
==========================================
Files 128 128
Lines 6284 6276 -8
Branches 1069 1063 -6
==========================================
- Hits 5112 5087 -25
- Misses 1157 1174 +17
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@harmonyharmo Any updates on this? Does it work on MV2? |
registration: "runtime"
for MV2
My console logs after installing it, it builds up successfully with this little warning: *ignore the following dependencies error, idk why it comes, will look into it, but it is coming for sometime and isn't related to this issue |
@prakhartiwari0 Does it work in dev mode and in production builds? How are you injecting the scripts in MV2? |
Well I am not... Are you asking something else? Please explain, I'm a dumb dev lol maybe I didn't get your question. |
Hi it works on MV2 I tested and no errors. |
Thanks for helping make WXT better! |
Overview
Allow scripts to not register with manifest.json for MV2
Manual Testing
add scripts to not register with manifest.json for MV2. now it builds successfully.
Related Issue
This PR closes #1428