Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recreating keyboardShortcuts interface on file changes. #1465

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nishu-murmu
Copy link
Contributor

Overview

I noticed that keyboard shortcuts weren't working after files were being saved or HMR was triggered.
Hope this fixes it.

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit d077bb0
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67c6e41ebe0e560008dbdd64
😎 Deploy Preview https://deploy-preview-1465--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nishu-murmu nishu-murmu changed the title fix: restarting keyboardShortcuts listener on file changes. fix: recreating keyboardShortcuts interface on file changes. Feb 28, 2025
Copy link
Member

@Timeraa Timeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was noticing this too but wouldn't this potentially be a memory leak since we keep creating it?

@nishu-murmu
Copy link
Contributor Author

Was noticing this too but wouldn't this potentially be a memory leak since we keep creating it?

Yeah, now that I think about it, it really can be. as such there are already existing issues for windows.
We can just close the listeners instead of the interface. That way only one interface will be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants