Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hooks #419

Merged
merged 4 commits into from
Feb 4, 2024
Merged

feat: Hooks #419

merged 4 commits into from
Feb 4, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Feb 4, 2024

This closes #414, #417, #405.

// wxt.config.ts
export default defineConfig({
  hooks: {
    build: {
      async before() {
        // Check types before building
        await execa("tsc --noEmit")
      },
    },
  },
});

Hooks implemented:

  • ready
  • build:before
  • build:manifestGenerated
  • build:done
  • entrypoints:resolved
  • entrypoints:grouped

I have also setup E2E tests to call startServer, so we can add E2E tests for dev mode, which are sorely needed!

Todo

  • Use hookable
  • Update config
  • Call hooks

@aklinker1 aklinker1 self-assigned this Feb 4, 2024
Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit da60375
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65c01ee87c6cd700084694ea
😎 Deploy Preview https://deploy-preview-419--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title Hooks feat: Hooks Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb02264) 81.95% compared to head (da60375) 85.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   81.95%   85.50%   +3.55%     
==========================================
  Files         107      107              
  Lines        7763     7837      +74     
  Branches      710      754      +44     
==========================================
+ Hits         6362     6701     +339     
+ Misses       1387     1123     -264     
+ Partials       14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review February 4, 2024 23:32
@aklinker1 aklinker1 mentioned this pull request Feb 4, 2024
@aklinker1 aklinker1 merged commit 21636de into main Feb 4, 2024
17 checks passed
@aklinker1 aklinker1 deleted the hooks branch February 4, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant