Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't default to dev mode for production builds when using vite-node loader #877

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Jul 28, 2024

This closes #873.

This does cause vite-node's dev server to run in different modes when doing wxt vs wxt build, but I don't expect that to cause any problems.

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit cb1fa2e
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66a666c66ce4ab0008626c33
😎 Deploy Preview https://deploy-preview-877--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 marked this pull request as ready for review July 28, 2024 15:43
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (fb22bea) to head (cb1fa2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   82.46%   82.60%   +0.14%     
==========================================
  Files         124      124              
  Lines        6512     6513       +1     
  Branches     1094     1087       -7     
==========================================
+ Hits         5370     5380      +10     
+ Misses       1128     1119       -9     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 24cd01d into main Jul 28, 2024
16 checks passed
@aklinker1 aklinker1 deleted the vite-node-dev-flag-fix branch July 28, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since version 0.19.0, the build command's env has been set to DEV: true.
1 participant