fix: Properly overload import.meta.env with WXT's own environment globals
#966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1natsu172
commented
Sep 3, 2024
aklinker1
requested changes
Sep 3, 2024
|
Merged this PR with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
- Coverage 81.90% 81.90% -0.01%
==========================================
Files 125 125
Lines 6605 6604 -1
Branches 1100 1100
==========================================
- Hits 5410 5409 -1
Misses 1181 1181
Partials 14 14 ☔ View full report in Codecov by Sentry. |
1natsu172
force-pushed
the
fix-type-declaration
branch
from
a00ce4a to
99bbb93
Compare
1natsu172
force-pushed
the
fix-type-declaration
branch
from
99bbb93 to
e51d2ac
Compare
|
Haha, I missed the local rebase but it's maybe ok now 😅 |
aklinker1
changed the title
import.meta.env with WXT's own environment globals
aklinker1
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #935
I copied vite's implement style https://github.com/vitejs/vite/blob/main/packages/vite/types/importMeta.d.ts. It seems that module augmentation is not allowed because
importis a top-level scope.TS docs:
completion screenshot
