Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pyproject.toml with cylc lint settings #46

Merged
merged 9 commits into from
Sep 9, 2022

Conversation

wxtim
Copy link
Owner

@wxtim wxtim commented Sep 9, 2022

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

wxtim and others added 9 commits August 18, 2022 08:55
….com:wxtim/cylc into allow_pyproject.toml_with_cylc_lint_settings

* 'allow_pyproject.toml_with_cylc_lint_settings' of github.com:wxtim/cylc:
  Update setup.cfg
….com:wxtim/cylc into allow_pyproject.toml_with_cylc_lint_settings

* 'allow_pyproject.toml_with_cylc_lint_settings' of github.com:wxtim/cylc:
  Fix FileNotFoundError when scanning path that doesn't exist
  py: support cPython 3.10
@wxtim wxtim merged commit 86575c0 into master Sep 9, 2022
wxtim added a commit that referenced this pull request Sep 9, 2022
* allow pyproject.toml with cylc lint settings
Co-authored-by: Ronnie Dutta <[email protected]>
wxtim added a commit that referenced this pull request Sep 9, 2022
* allow pyproject.toml with cylc lint settings
Co-authored-by: Ronnie Dutta <[email protected]>
wxtim added a commit that referenced this pull request Sep 14, 2022
* allow pyproject.toml with cylc lint settings
Co-authored-by: Ronnie Dutta <[email protected]>

response to review

Made cylc lint accept only one argument.
wxtim added a commit that referenced this pull request Oct 6, 2022
lint: allow pyproject.toml with cylc lint settings (#46)

* Support pyproject.toml with cylc lint settings.
* Made cylc lint accept only one argument.
* Made sure that line length checks are ignored when added to the ignore list.
* Remove now unused check
wxtim pushed a commit that referenced this pull request Mar 11, 2024
Prevent malformed `--pre` options taking the scheduler down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant