Fix return value for ExtractFieldPathAsString

wzjgo · Jun 4, 2019 · 40f3f3b · 40f3f3b
1 parent 9f85c5c
commit 40f3f3b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/pkg/fieldpath/fieldpath.go b/pkg/fieldpath/fieldpath.go
@@ -46,7 +46,7 @@ func FormatMap(m map[string]string) (fmtStr string) {
 func ExtractFieldPathAsString(obj interface{}, fieldPath string) (string, error) {
 	accessor, err := meta.Accessor(obj)
 	if err != nil {
-		return "", nil
+		return "", err
 	}
 
 	if path, subscript, ok := SplitMaybeSubscriptedPath(fieldPath); ok {

diff --git a/pkg/fieldpath/fieldpath_test.go b/pkg/fieldpath/fieldpath_test.go
@@ -33,9 +33,10 @@ func TestExtractFieldPathAsString(t *testing.T) {
 		expectedMessageFragment string
 	}{
 		{
-			name:      "not an API object",
-			fieldPath: "metadata.name",
-			obj:       "",
+			name:                    "not an API object",
+			fieldPath:               "metadata.name",
+			obj:                     "",
+			expectedMessageFragment: "object does not implement the Object interfaces",
 		},
 		{
 			name:      "ok - namespace",