Add hidden attribute to the header menu button

This follows on from the corresponding upstream change[0][1], released in 4.3.0 [0] alphagov/govuk-frontend#2727 [1] https://github.com/alphagov/govuk-frontend/pull/2727/files#diff-dcc9d461905ec3f2d5c9a73c4c7bc09499b0c8265fe7e32c097b0e6649e1106fL64 Co-authored-by: Frankie Roberto <[email protected]>
x-govuk · Aug 11, 2022 · 3eed8de · 3eed8de
1 parent 4aaedb5
commit 3eed8de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/components/govuk_component/header_component.html.erb b/app/components/govuk_component/header_component.html.erb
@@ -37,7 +37,7 @@
 
         <% if navigation_items.any? %>
           <%= tag.nav(**navigation_html_attributes) do %>
-            <%= tag.button("Menu", type: "button", class: %w(govuk-header__menu-button govuk-js-header-toggle), aria: { controls: "navigation", label: menu_button_label }) %>
+            <%= tag.button("Menu", type: "button", class: %w(govuk-header__menu-button govuk-js-header-toggle), hidden: true, aria: { controls: "navigation", label: menu_button_label }) %>
             <ul id="navigation" class="govuk-header__navigation-list">
               <% navigation_items.each do |item| %>
                 <%= item %>

diff --git a/spec/components/govuk_component/header_component_spec.rb b/spec/components/govuk_component/header_component_spec.rb
@@ -296,7 +296,7 @@
 
         specify 'the button is rendered' do
           expect(rendered_content).to have_tag('div', with: { class: 'govuk-header__content' }) do
-            with_tag('button', with: { class: button_classes, 'aria-label' => button_aria_label }, text: button_text)
+            with_tag('button', with: { class: button_classes, 'aria-label' => button_aria_label, hidden: 'hidden' }, text: button_text)
           end
         end