Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassAliasingMapper itemTypeAsAttribute never works. #28

Closed
patelm5 opened this issue Oct 6, 2015 · 1 comment
Closed

ClassAliasingMapper itemTypeAsAttribute never works. #28

patelm5 opened this issue Oct 6, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@patelm5
Copy link

patelm5 commented Oct 6, 2015

I'm pretty sure this can never work, whatever it's intended purpose ( I was trying to create a Shortname class mapper which still respected the aliases. )

public boolean itemTypeAsAttribute(final Class<?> clazz) { return classToName.containsKey(clazz); }

The keys in the map are String type.

@joehni
Copy link
Member

joehni commented Oct 6, 2015

Thanks for heads-up. Fortunately the method is never called, it's a left-over of an old implementation.

@joehni joehni added the bug label Oct 6, 2015
@joehni joehni added this to the 1.4.x milestone Oct 6, 2015
@joehni joehni self-assigned this Oct 6, 2015
joehni added a commit that referenced this issue Oct 9, 2015
ClassAliaslingMapper.aliasIsAttribute(String).
@joehni joehni closed this as completed in adcd808 Oct 9, 2015
@joehni joehni modified the milestones: 1.4.x, 1.4.9 Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants