pop unmarshalled type on exception #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been proposed before, however, it is not valid. XStream is based on an incoming data stream. After an exception the state and location of the pointer in that stream is simply undefined. XStream cannot guarantee anything for the underlying stream especially if a caller wants to continue with the processing of that stream. The raised exception has to quit the complete unmarshalling process and therefore it does not make sense to reset the state of the stack, when the complete object that holds the stack is no longer valid. |
|
Thanks for the feedback! |
|
see #106 for explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when unmarshal throws an exception then the type is not removed from the stack.
a jenkins specific bug description is available at jenkinsci#2