Add support for spatial averaging parallelism via Dask #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvothecoder
added
Priority: Medium
type: bug
tomvothecoder
requested changes
Oct 25, 2021
|
Note that this needs more work: #115 (comment) |
- Add `with xr.set_options(keep_attrs=True)` to `_swap_lon_axes()` to fix tests - Add tests for `_swap_lon_axes()` and chunking - Update name of tests
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 336 341 +5
=========================================
+ Hits 336 341 +5
Continue to review full report at Codecov.
|
pochedls
commented
Oct 29, 2021
There was a problem hiding this comment.
@tomvothecoder - This looks good to me. It is passing tests and giving the correct output now.
tomvothecoder
approved these changes
Oct 29, 2021
tomvothecoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to fix #115. It simply updates the
dataarray.valuesattribute directly (when applicable) to maintain compatibility with chunked dataarray data (for spatial averaging routines).NotImplementedError: xarray can't set arrays with multiple array indices to dask yet.#115Checklist
If applicable: