-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exception for coords of len <= 1 or multidimensional coords in fill_missing_bounds()
#141
Conversation
@@ -96,19 +96,27 @@ def names(self) -> List[str]: | |||
) | |||
) | |||
|
|||
def fill_missing(self) -> xr.Dataset: | |||
def fill_missing_bounds(self) -> xr.Dataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was named as fill_missing()
since it is encapsulated under bounds accessor (ds.bounds.fill_missing()
/DatasetBounds(ds).fill_missing()
), which explains the target is filling the missing bounds.
However, it has been changed to fill_missing_bounds()
so that it is in alignment with ds.xcdat.fill_missing_bounds()
/XCDATAccessor(ds).fill_missing_bounds()
to make APIs consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice change! Thank you.
Hi @chengzhuzhang, this PR is ready for review. Thanks! |
fill_missing_bounds()
fill_missing_bounds()
@@ -96,19 +96,27 @@ def names(self) -> List[str]: | |||
) | |||
) | |||
|
|||
def fill_missing(self) -> xr.Dataset: | |||
def fill_missing_bounds(self) -> xr.Dataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice change! Thank you.
- Rename `fill_missing()` to `fill_missing_bounds()` - Update logger name to `root` in `bounds.py`
f893751
to
1b9caea
Compare
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 342 345 +3
=========================================
+ Hits 342 345 +3
Continue to review full report at Codecov.
|
Description
fill_missing()
tofill_missing_bounds()
-- breaking changeroot
inbounds.py
Checklist
If applicable:
v0.2.0