Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #187

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 11, 2022

Description

Summary of Changes:

  • Remove typing_extensions from setup.py and conda env dependencies
  • Update imports from typing_extensions to typing
  • Remove Python 3.7 from CI build matrix

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Remove `typing_extensions` from dependencies
- Update imports from `typing_extensions` to `typing`
- Remove Python 3.7 from CI build matrix
@tomvothecoder tomvothecoder added type: devops Testing, CI/CD, systems configuration Priority: High labels Jan 11, 2022
@tomvothecoder tomvothecoder self-assigned this Jan 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #187 (360bbc9) into main (201a575) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #187   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          381       418   +37     
=========================================
+ Hits           381       418   +37     
Impacted Files Coverage Δ
xcdat/__init__.py 100.00% <100.00%> (ø)
xcdat/axis.py 100.00% <100.00%> (ø)
xcdat/bounds.py 100.00% <100.00%> (ø)
xcdat/dataset.py 100.00% <100.00%> (ø)
xcdat/spatial_avg.py 100.00% <100.00%> (ø)
xcdat/xcdat.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a392f...360bbc9. Read the comment docs.

@tomvothecoder tomvothecoder merged commit 2df754a into main Jan 11, 2022
@tomvothecoder tomvothecoder deleted the devops/185-drop-python-3.7 branch January 11, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: devops Testing, CI/CD, systems configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
2 participants