-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename spatial file and class #207
Conversation
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 8 9 +1
Lines 381 742 +361
==========================================
+ Hits 381 742 +361
Continue to review full report at Codecov.
|
Hi @pochedls, the diff in this PR is pretty small, but I wanted to see if you had any comments first before I merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't actually pull this code and test it, but I did look through it and I approve. I didn't Immediately understand some of the superficial changes, e.g., from comment "Access spatial averaging method" to "Call spatial averaging method" but I assume there is a consistency reason for the change.
Overall, I like spatial better than spatial_avg
Yeah, those are just minor changes to align with programmatic terms. I'll comment next time on those types of changes since they aren't obvious.
Sounds good! I will merge this PR, thanks. |
- Rename `spatial_avg.py` to `spatial.py` - Rename `SpatialAverageAccessor` to `SpatialAccessor` - These changes enable future extensibility in case methods or functions related to spatial axes are integrated into the xcdat package.
5730e24
to
22a5f7a
Compare
Description
spatial_avg.py
tospatial.py
#206spatial_avg.py
tospatial.py
SpatialAverageAccessor
toSpatialAccessor
Checklist
If applicable: