Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters safe warnings. #276

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Filters safe warnings. #276

merged 1 commit into from
Aug 3, 2022

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Jul 20, 2022

Description

Filters some safe to ignore warnings.

Two test methods raised RuntimeWarning: invalid value encountered in true_divide.

These warnings will still appear in user code as they may be significant outside of testing.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomvothecoder tomvothecoder merged commit 3717b71 into xCDAT:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix warnings in test suite
2 participants