Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify workspace settings with settings.json #297

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

tomvothecoder
Copy link
Collaborator

Description

This PR unifies the workspace settings with the settings.json file since it is redundant to have both. The workspace settings is now the primary way to distribute settings among developers using VS Code.

  • Closes #N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Aug 3, 2022
@tomvothecoder tomvothecoder merged commit 75baf66 into main Aug 3, 2022
@tomvothecoder tomvothecoder deleted the unify-vscode-settings branch August 3, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant