Fixes xesmf flag #374
Merged
Fixes xesmf flag #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should resolve issues with curvilinear grids not working (#339). |
tomvothecoder
added
type: bug
tomvothecoder
approved these changes
Oct 24, 2022
Comment on lines
+441
to
+451
| @pytest.mark.parametrize( | ||
| "name,value,attr_name", | ||
| [ | ||
| ("periodic", True, "_periodic"), | ||
| ("extrap_method", "inverse_dist", "_extrap_method"), | ||
| ("extrap_method", "nearest_s2d", "_extrap_method"), | ||
| ("extrap_dist_exponent", 0.1, "_extrap_dist_exponent"), | ||
| ("extrap_num_src_pnts", 10, "_extrap_num_src_pnts"), | ||
| ("ignore_degenerate", False, "_ignore_degenerate"), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
I didn't know this pytest decorator exists. This is neat for easily testing different function/method parameters!
pochedls
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
This resolves most of the curvilinear gridding issues. I do not have an exact match with CDAT, but when I spot-checked the grid cell differences were order 10$^{-5}$. In looking at 58 models, 9 had issues, but they appeared to be known issues (I think compared to more than 30 exceptions before?):
| Error | Instances |
|---|---|
TypeError: buffer is too small for requested array |
1 |
KeyError: "Receive multiple variables for key 'longitude': {'lon', 'longitude'}. Expected only one. Please pass a list ['longitude'] instead to get all variables matching 'longitude'." |
2 |
KeyError: 'lon_b' |
3 |
ValueError: Bounds format not understood. Got ('nj', 'ni', 'vertices') with shape (384, 320, 2). |
1 |
KeyError: "No results found for 'longitude'." |
1 |
xarray.core.merge.MergeError: conflicting values for variable 'vertices_latitude' on objects to be combined. You can skip this check by specifying compat='override'. |
1 |
I think this PR is good to go. Thanks for sorting this out @jasonb5!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
ignore_degeneratenot being passed through to xESMF regridder object.Checklist
If applicable: