Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQs section for temporal metadata #383

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Nov 9, 2022

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Update `NON_CF_TIME_UNITS` static list to include singular version of units
@tomvothecoder tomvothecoder added the type: docs Updates to documentation label Nov 9, 2022
@tomvothecoder tomvothecoder self-assigned this Nov 9, 2022
docs/faqs.rst Outdated Show resolved Hide resolved
docs/faqs.rst Outdated Show resolved Hide resolved
docs/faqs.rst Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6b6bd00) compared to base (c6587b8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1242      1242           
=========================================
  Hits          1242      1242           
Impacted Files Coverage Δ
xcdat/dataset.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomvothecoder tomvothecoder merged commit e5ef35e into main Nov 9, 2022
@tomvothecoder tomvothecoder deleted the doc/336-calendar-info branch November 9, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants