[PR]: Remove deprecated features and APIs for next release #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvothecoder
changed the title
tomvothecoder
added
the
minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1588 1521 -67
=========================================
- Hits 1588 1521 -67 ☔ View full report in Codecov by Sentry. |
tomvothecoder
force-pushed
the
deprecation/626-various-deprs
branch
from
8fa2aac to
27bb88b
Compare
tomvothecoder
commented
Mar 21, 2024
There was a problem hiding this comment.
Hey @jasonb5, can you review this PR and make sure I've removed all of the correct deprecated code for the regridder? I am aiming to merge this PR before releasing v0.7.0 in the next week or so.
- Remove `horizontal_xesmf()` and `horizontal_regrid2()` - Remove `**kwargs` from `create_grid()` and `_deprecated_create_grid()` - Remove `add_bounds` accepting boolean arg in `open_dataset()`, `open_mfdataset()` and `_postprocess_dataset()`
- Remove `lxml` dependency
- Add ValueError conditional back to `create_grid()`
tomvothecoder
force-pushed
the
deprecation/626-various-deprs
branch
from
27bb88b to
c5cdab3
Compare
|
I did another self-review and the build is passing. I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
open_dataset()andopen_mfdataset()#604Summary of Changes
horizontal_xesmf()andhorizontal_regrid2()**kwargsfromcreate_grid()and_deprecated_create_grid()add_boundsaccepting boolean arg inopen_dataset(),open_mfdataset()and_postprocess_dataset()open_dataset()andopen_mfdataset()lxmldependency fromci.ymlanddev.ymlChecklist
If applicable: