-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regridding notebook for v0.7.0 #646
Conversation
Only a few minor changes that makes note books to run. Some changes noted:
|
I don't mind including notebook setup instructions, but I had included the following text in order to avoid repeating the instructions across all notebooks:
|
I was able to use the Python kernel from the Commands used: $ conda create -n xcdat_notebook -c conda-forge xcdat xesmf matplotlib ipython ipykernel cartopy nc-time-axis jupyter
$ conda activate xcdat_notebook
$ jupyter notebook |
@tomvothecoder I did not know Python3 (ipykernel) is the one with xcdat. I thought it is just bare-bone python3. I agree |
If Jupyter is invoked from within a conda environment ( On the other hand, public Jupyter instances would probably have multiple kernels listed (e.g., NERSC Jupyter Hub) since kernels are manually registered to that public instance. We can either 1) add a note on the notebooks to let the the user know |
I just confirmed that no other kernels are registered in the Jupyter instance invoked by |
I think it is a good solution! |
Thanks for the screenshot! Yeah I'm not sure why those kernels are registered with the Jupyter instance invoked through In any case, I will update all the notebooks using both solutions above in a separate PR. |
Thank you for implementing it! |
@chengzhuzhang @tomvothecoder I do see the visual difference in the last example, this would be expected as I reworked how masking worked. The updated result should be more accurate, it appears to be visually. |
Got it. Thank you for the calcification @jasonb5 |
Great! @chengzhuzhang You can merge this PR if you think it is ready. |
9193509
to
5271b73
Compare
Description
For addressing: #589 (comment) but focus only on horizontal and vertical regridding notebooks
Checklist
If applicable: