-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update temporal.py to properly handle piControl simulations #696
Conversation
pre-commit shows following error for
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1546 1546
=========================================
Hits 1546 1546 ☔ View full report in Codecov by Sentry. |
- Remove unused type ignore comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the mypy
warning that was appearing with the latest version of xarray
. This PR looks good to me. Thank you Jiwoo.
@tomvothecoder thank you for your review! I am merging it now. |
Description
PiControl simulations can have time step labels as like "0001-01-01". To not lose the first "000" in year, #695 proposed this fix.
self.dim
inTemporalAccessor
from Hashable to a string to fix mypy warning and remove type ignore commentsChecklist
If applicable: