Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy constraint to >=2.0.0,<=3.0.0 #711

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Oct 29, 2024

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Update sub-dependencies to min version that supports NumPy 2.0
@tomvothecoder
Copy link
Collaborator Author

Will need to release a new version of xCDAT for this (v0.7.3)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (96bc649) to head (57c6288).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #711   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1555      1555           
=========================================
  Hits          1555      1555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 7 to 19
# Base - required for building the package.
# =========================================
- python >=3.9
- cf_xarray >=0.7.3
- cf_xarray >=0.9.1
- cftime
- dask
- netcdf4
- numpy >=1.23.0,<2.0
- numpy >=2.0.0,<=3.0.0
- pandas
- python-dateutil
- xarray >=2022.02.0
- xesmf >=0.7.0
- xarray >=2024.03.0
- xesmf >=0.8.7
- xgcm
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xylar, I'm checking in with you to make sure these constraints are fine with E3SM Unified.

In addition to the new numpy constraint, I've constrained other packages to the minimum version that supports numpy 2.0.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's great! The only constraint there that clashes with current E3SM-Unified is xarray but you're absolutely right that we're going to have to update that as well to support numpy 2.0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for confirming

@tomvothecoder tomvothecoder marked this pull request as ready for review October 30, 2024 19:00
@tomvothecoder tomvothecoder merged commit b1a72fc into main Oct 31, 2024
10 checks passed
@tomvothecoder tomvothecoder deleted the bug/688-numpy-constraint branch October 31, 2024 19:38
This was referenced Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants