-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numpy constraint to >=2.0.0,<=3.0.0
#711
Conversation
- Update sub-dependencies to min version that supports NumPy 2.0
Will need to release a new version of xCDAT for this (v0.7.3) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1555 1555
=========================================
Hits 1555 1555 ☔ View full report in Codecov by Sentry. |
# Base - required for building the package. | ||
# ========================================= | ||
- python >=3.9 | ||
- cf_xarray >=0.7.3 | ||
- cf_xarray >=0.9.1 | ||
- cftime | ||
- dask | ||
- netcdf4 | ||
- numpy >=1.23.0,<2.0 | ||
- numpy >=2.0.0,<=3.0.0 | ||
- pandas | ||
- python-dateutil | ||
- xarray >=2022.02.0 | ||
- xesmf >=0.7.0 | ||
- xarray >=2024.03.0 | ||
- xesmf >=0.8.7 | ||
- xgcm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xylar, I'm checking in with you to make sure these constraints are fine with E3SM Unified.
In addition to the new numpy constraint, I've constrained other packages to the minimum version that supports numpy 2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's great! The only constraint there that clashes with current E3SM-Unified is xarray but you're absolutely right that we're going to have to update that as well to support numpy 2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for confirming
Description
np.NaN
was removed in the NumPy 2.0 release. Usenp.nan
instead." #668Checklist
If applicable: