Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new Braavos class hash when fetching #109

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

hqueue
Copy link
Contributor

@hqueue hqueue commented Nov 20, 2024

Support new Braavos class hash when fetching a Braavos account

Close #108

feat: support new Braavos class hash when fetching

Signed-off-by: Hyung-Kyu Choi <[email protected]>
@barretodavid
Copy link

This would be quite useful to have it merged @xJonathanLEI

Copy link
Owner

@xJonathanLEI xJonathanLEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked and confirmed this is indeed the correct class hash.

Additional work needed to check if it's safe to init and deploy this new hash though, depending on whether there's any changes on constructor.

@xJonathanLEI xJonathanLEI merged commit 0fcc31d into xJonathanLEI:master Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown class hash error when fetching recently deployed Braavos account
3 participants