Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix known account class for braavos #60

Closed

Conversation

0xcoburn
Copy link

@0xcoburn 0xcoburn commented Jan 3, 2024

update known account class

update known account class
changed original to BraavosMainnetGoerli
and added BraavosSepolia
@xJonathanLEI
Copy link
Owner

Thanks for the PR! I'm not sure we should add a AccountVariantType variant for this though? These variants exist only to deal with account classes with different interfaces so that they need to be treated differently when fetching. If the new Braavos class exposes the same interface (as far as our use of it is concerned, of course), we can just add the hash.

I will have to check which is the case though.

@xJonathanLEI
Copy link
Owner

Branch does not compile.

@xJonathanLEI
Copy link
Owner

Superseded by d2c3342.

@0xcoburn 0xcoburn deleted the Fix-Known-Account-Error branch January 6, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants