Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlighting should work even when striped style is applied #682

Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix: highlighting should work even when striped style is applied #682

merged 2 commits into from
Jun 23, 2020

Conversation

mihai-sysbio
Copy link
Contributor

Description

When using the striped class, the highlight only works on non-striped rows.

Fix

Probably not the best way to fix this, but if the hover styling is !important, then it does not get overridden by the _striped.scss styling. I guess one should play with the selectors and their order instead, but this fix seems to work fine.

@mihai-sysbio
Copy link
Contributor Author

@xaksis any feedback?

@TheJaredWilcurt
Copy link
Collaborator

let's not use !important if we are having specificity problems now to cause a need to override this, then we will have them again in the future and there is no overriding !important. Find a cleaner way around this.

@mihai-sysbio
Copy link
Contributor Author

Fair point @TheJaredWilcurt, see above another way to achieve the same result. I'm not really happy with changing the import order, but fundamentally the styling order is the problem.

@xaksis xaksis merged commit c874ee0 into xaksis:master Jun 23, 2020
p0psicles pushed a commit to p0psicles/vue-good-table that referenced this pull request Jun 24, 2020
…sis#682)

* fix: highlighting should work even when striped style is applied

* refactor: relying on style order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants