address review

xamarin · Feb 23, 2024 · b011e65 · b011e65
1 parent 7d2f8cb
commit b011e65
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/tests/common/DotNet.cs b/tests/common/DotNet.cs
@@ -117,7 +117,7 @@ public static ExecutionResult InstallTool (string tool, string path)
 		{
 			var installed = ExecuteCommand (Executable, "tool", "list", "--tool-path", path);
 			if (!installed.StandardOutput.ToString ().Contains (tool))
-				ExecuteCommand (Executable, "tool", "install", tool, "--tool-path", path);
+				installed = ExecuteCommand (Executable, "tool", "install", tool, "--tool-path", path);
 			return installed;
 		}
 

diff --git a/tests/dotnet/UnitTests/Extensions.cs b/tests/dotnet/UnitTests/Extensions.cs
@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics;
 using System.IO;
 
 #nullable enable

diff --git a/tests/dotnet/UnitTests/ProjectTest.cs b/tests/dotnet/UnitTests/ProjectTest.cs
@@ -1693,7 +1693,7 @@ public void SourcelinkTest (ApplePlatform platform, string runtimeIdentifiers, s
 			var tool = "sourcelink";
 			var toolPath = Directory.GetCurrentDirectory ();
 			DotNet.InstallTool (tool, toolPath);
-			var test = DotNet.RunTool ($"{toolPath}/{tool}", "test", $"{pdbFile}");
+			var test = DotNet.RunTool (Path.Combine (toolPath, tool), "test", pdbFile!);
 
 			Assert.AreEqual ($"sourcelink test passed: {pdbFile}", test.StandardOutput.ToString ());
 		}