[CoreFoundation] Add support for xcode 13 beta 5. #12552
Conversation
mandel-macaque
added
the
note-highlight
src/CoreFoundation/CFBundle.cs
Outdated
| [Introduced (PlatformName.MacOSX, 11, 0)] | ||
| [MacCatalyst (15,0)] | ||
| #else | ||
| [UnsupportedOSPlatform ("ios"), UnsupportedOSPlatform ("tvos"), SupportedOSPlatform ("macos11.0"), SupportedOSPlatform ("maccatalyst15.0")] |
There was a problem hiding this comment.
That code is not complied for iOS or tvOS so UnsupportedOSPlatform is not helpful on a private member.
On a public member is has some value (documentation), e.g. you doing Mac work but you'll notice your API won't be available if the code eventually needs to be used on iOS.
However on a private member it's only useful to have availability because it helps introspection to detect mistakes. That code won't be present for (example) iOS so introspection won't be using it. So this is only extraneous metadata.
There was a problem hiding this comment.
Should I be doing something similar for the ones that I am doing?
| [Introduced (PlatformName.MacOSX, 11, 0)] | ||
| [MacCatalyst (15,0)] | ||
| #else | ||
| [UnsupportedOSPlatform ("ios"), UnsupportedOSPlatform ("tvos"), SupportedOSPlatform ("macos11.0"), SupportedOSPlatform ("maccatalyst15.0")] |
src/CoreFoundation/CFBundle.cs
Outdated
| [Introduced (PlatformName.MacOSX, 11, 0)] | ||
| [MacCatalyst (15,0)] | ||
| #else | ||
| [UnsupportedOSPlatform ("ios"), UnsupportedOSPlatform ("tvos"), SupportedOSPlatform ("macos11.0"), SupportedOSPlatform ("maccatalyst15.0")] |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results23 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 108 tests passed 🎉Pipeline on Agent XAMBOT-1109.BigSur' |
|
I confirmed with @dalexsoto landing this after the changes :) |
The deprecations form the headers was done in a previous PR and are already present.