[Xcode13.2] Bump to Xcode 13.2 RC #13497
Conversation
Breaking changes addressed for legacy * HomeKit * CallKit * CoreLocation
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results13 tests failed, 124 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
|
Looks reasonable, but I've been out of binding practice for awhile so only tiny 👍. My biggest concern here is API compat, which we'll have to lean on API diff + folks here. |
src/usernotifications.cs
Outdated
| [NoWatch, NoTV, NoMacCatalyst, NoMac, iOS (15,2)] | ||
| [Static] | ||
| [Export ("ringtoneSoundNamed:")] | ||
| UNNotificationSound GetRingtoneSoundNamed (string name); |
There was a problem hiding this comment.
| UNNotificationSound GetRingtoneSoundNamed (string name); | |
| UNNotificationSound GetRingtoneSound (string name); |
|
|
||
| namespace CoreLocation { | ||
|
|
||
| #if !XAMCORE_4_0 && !WATCH | ||
| #nullable enable | ||
| #if !NET && !WATCH |
| @@ -27,7 +27,8 @@ public enum CXCallDirectoryEnabledStatus : long { | |||
| Enabled = 2 | |||
| } | |||
|
|
|||
| [iOS (10, 0), Mac (11, 0)] | |||
| #if !MONOMAC | |||
There was a problem hiding this comment.
Do you need the #if !MONOMAC if you're also doing [NoMac]?
| @@ -48,11 +48,12 @@ public enum CLProximity : long { | |||
| Far | |||
| } | |||
|
|
|||
| #if !MONOMAC | |||
There was a problem hiding this comment.
This shouldn't be needed, since the enum is NoMac
There was a problem hiding this comment.
I think the ErrorDomain was still generated I can double check this in the morning
dalexsoto
changed the title
|
@rolfbjarne I think I have addressed all the feedback and also updated to Xcode 13 RC which has only one change on intents. I'll check on the ErrorDomain in the morning and fix if needed on a separated PR but that should not affect the codepath for this PR |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 192 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results4 tests failed, 191 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
due to time constrains ✅not waiting on xtro. |
* [Xcode13.2] Bump to Xcode 13.2 Beta 2 Breaking changes addressed for legacy * HomeKit * CallKit * CoreLocation * [xcode13.2] Bump to Xcode 13.2 RC and apply feedback * [AppKit] Fix missing Notifications * Fix xtro
* [Xcode13.2] Bump to Xcode 13.2 RC (#13497) * [Xcode13.2] Bump to Xcode 13.2 Beta 2 Breaking changes addressed for legacy * HomeKit * CallKit * CoreLocation * [xcode13.2] Bump to Xcode 13.2 RC and apply feedback * [AppKit] Fix missing Notifications * Fix xtro * [xcode13.2] Bump versions and use stable Xcode 13.2 * [monotouch-tests] Make TestAddingByComponents work on the last day of the year Happy New Year!! * NO BOM PLZ!
Breaking changes addressed for legacy (Legacy API diff seems happy)
Include all of Xcode13.2 changes but CHIP and MetalPerformanceShadersGraph.