Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileProvider] Update for Xcode14 binding #15790

Merged
merged 12 commits into from
Aug 31, 2022
Merged

[FileProvider] Update for Xcode14 binding #15790

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1f50805
Starting the FileProvider Xcode14 changes
Aug 23, 2022
b22abae
Next round of FileProvider
Aug 24, 2022
a5dd89c
remove statics and add ios attribute
Aug 25, 2022
1515c9c
changing this maccatalyst attribute
Aug 25, 2022
8af7c4f
use xamcore5 and add to ignores
Aug 26, 2022
75e3423
Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-FileProvi…
Aug 26, 2022
350df9c
move just the abstract inside the xamcore
Aug 27, 2022
fde18ea
Apply suggestions from code review
dalexsoto Aug 29, 2022
2c8f0c6
Add Newlines
Aug 29, 2022
d2dd1fa
Merge remote-tracking branch 'TJ/Xcode14-FileProvider-Beta4' into Xco…
Aug 29, 2022
17df5c7
Merge branch 'xcode14' into Xcode14-FileProvider-Beta4
dalexsoto Aug 30, 2022
461e603
Merge branch 'xcode14' into Xcode14-FileProvider-Beta4
dalexsoto Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/fileprovider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,8 +817,10 @@ interface NSFileProviderPendingSetEnumerator : NSFileProviderEnumerator {
[Export ("refreshInterval")]
double RefreshInterval { get; }

[NoWatch, NoTV, NoMacCatalyst, Mac (13, 0), iOS (16, 0)]
#if XAMCORE_5_0
[Abstract]
#endif
[NoWatch, NoTV, NoMacCatalyst, Mac (13, 0), iOS (16, 0)]
[Export ("maximumSizeReached")]
bool MaximumSizeReached { [Bind ("isMaximumSizeReached")] get; }
}
Expand Down
3 changes: 3 additions & 0 deletions tests/xtro-sharpie/api-annotations-dotnet/common-FileProvider.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# New abstract protocol member was added in Xcode14
# which is a breaking change so adding it to XAMCORE_5_0
!incorrect-protocol-member! NSFileProviderPendingSetEnumerator::isMaximumSizeReached is REQUIRED and should be abstract
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing eol at the end

dalexsoto marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 3 additions & 0 deletions tests/xtro-sharpie/common-FileProvider.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# New abstract protocol member was added in Xcode14
# which is a breaking change so adding it to XAMCORE_5_0
!incorrect-protocol-member! NSFileProviderPendingSetEnumerator::isMaximumSizeReached is REQUIRED and should be abstract
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

dalexsoto marked this conversation as resolved.
Show resolved Hide resolved