-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreLocation] Updates for Xcode 14.0.0 #15985
[CoreLocation] Updates for Xcode 14.0.0 #15985
Conversation
…amarin#15649)" Apple removed this framework from Xcode 14 RC This reverts commit d9cd069.
…json. Also move bash code from yml to a .sh file for easier reading, writing and debugging.
Fix parsing WorkloadRollback.json to not throw an error if an entry doesn't exist: Select-Object: /Users/builder/azdo/_work/_temp/7602a64f-206e-4a71-b5f3-f55f2812ad0c.ps1:13 Line | 13 | … versionData | Select-Object -ExpandProperty "microsoft.net.sdk.macos" | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | Property "microsoft.net.sdk.macos" cannot be found.
Doing a merge commit for this PR so we can revert the revert in the future for BackgroundAssets * Apple removed BackgroundAssets * Apple removed macOS 13.0 SDK * Apple Removed MacCat 16.0 SDK
@@ -474,6 +474,9 @@ partial interface CLLocationManager { | |||
[Export ("stopMonitoringLocationPushes")] | |||
void StopMonitoringLocationPushes (); | |||
|
|||
[Watch (9,0), NoTV, NoMac, NoiOS, NoMacCatalyst] | |||
[Export ("requestHistoricalLocationsWithPurposeKey:sampleCount:completionHandler:")] | |||
void RequestHistoricalLocation (string purposeKey, nint sampleCount, Action<NSArray<CLLocation>, NSError> handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this method could be [Async]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolfbjarne addressed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, yet do not land without the [Async] requested by rolf.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@tj-devel709 I think you'll have to close this PR and open a new one that targets xcode14.1, because the diff is weird. |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌No test package could be found for tests on macOS Mac Catalina (10.15) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌No test package could be found for tests on macOS M1 - Mac Big Sur (11.5) Pipeline on Agent |
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 12 tests failed, 148 tests passed. Failures❌ monotouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 59 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Closing here, will open up a PR in to the Xcode14.1 branch |
No description provided.