[msbuild] Warn when we detect that the app developer is trying to link with a static library when using Hot Restart. Fixes #17640. #18940
Conversation
…k with a static library when using Hot Restart. Fixes dotnet#17640. Warn when we detect that the app developer is trying to link with a static library when using Hot Restart, because we don't support linking with static libraries in that case. Also change the resource generation for Xamarin.iOS.Tasks.Windows project to generate the code-behind for the resources during the build (as opposed to by the IDE - which won't happen unless using an IDE, while the build will always happen). Fixes dotnet#17640.
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
| @@ -19,4 +19,7 @@ | |||
| <value>Info.plist file does not exist under {0}, please rebuild your project</value> | |||
| <comment>0: path</comment> | |||
| </data> | |||
| <data name="HotRestartStaticLibraryNotSupported" xml:space="preserve"> | |||
There was a problem hiding this comment.
Is the values inside this resx file something that we'd want localized?
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 4 tests failed, 226 tests passed. Failures❌ monotouch tests [attempt 2]
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2630). |
Warn when we detect that the app developer is trying to link with a static
library when using Hot Restart, because we don't support linking with static
libraries in that case.
Also change the resource generation for Xamarin.iOS.Tasks.Windows project to
generate the code-behind for the resources during the build (as opposed to by
the IDE - which won't happen unless using an IDE, while the build will always
happen).
Fixes #17640.