-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcode15.1] Bump to Xcode 15.1 Beta 3 #19563
Conversation
|
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[NoWatch, NoTV, Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||
[BaseType (typeof (NEProvider))] | ||
[DisableDefaultCtor] | ||
interface NEFailureHandlerProvider { | ||
[NoWatch, NoTV, Mac (14, 0), iOS (17, 0)] | ||
[Export ("handleFailure:completionHandler:")] | ||
[Async] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes apple. iOS 17 and MacOS 14 and you deprecate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apple deprecating in a .1 release apis from the last release.. the worst part is that it is not a surprise :/
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 32 tests failed, 196 tests passed. Failures❌ cecil tests [attempt 4]
Html Report (VSDrops) Download ❌ dotnettests tests [attempt 4]
Html Report (VSDrops) Download ❌ introspection tests [attempt 4]Html Report (VSDrops) Download ❌ monotouch tests [attempt 4]
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
IOS_PACKAGE_VERSION=17.1.1.$(IOS_COMMIT_DISTANCE) | ||
MAC_PACKAGE_VERSION=9.1.1.$(MAC_COMMIT_DISTANCE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be:
IOS_PACKAGE_VERSION=17.1.1.$(IOS_COMMIT_DISTANCE) | |
MAC_PACKAGE_VERSION=9.1.1.$(MAC_COMMIT_DISTANCE) | |
IOS_PACKAGE_VERSION=17.2.0.$(IOS_COMMIT_DISTANCE) | |
MAC_PACKAGE_VERSION=9.2.0.$(MAC_COMMIT_DISTANCE) |
[Obsolete (Constants.ApiRemovedGeneral)] | ||
[Register ("NEFailureHandlerProvider", SkipRegistration = true)] | ||
public class NEFailureHandlerProvider : NEProvider { | ||
public override NativeHandle ClassHandle => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
|
||
protected NEFailureHandlerProvider (NSObjectFlag t) : base (t) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
protected internal NEFailureHandlerProvider (NativeHandle handle) : base (handle) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
|
||
public unsafe virtual void HandleFailure (NSError error, Action completionHandler) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
public unsafe virtual Task HandleFailureAsync (NSError error) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be !XAMCORE_5_0
[Obsolete (Constants.ApiRemovedGeneral)] | ||
public unsafe partial class SFAnalysisContextTag { | ||
|
||
[Obsolete (Constants.ApiRemovedGeneral)] | ||
[EditorBrowsable (EditorBrowsableState.Never)] | ||
public static NSString LeftContext => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
|
||
[Obsolete (Constants.ApiRemovedGeneral)] | ||
[EditorBrowsable (EditorBrowsableState.Never)] | ||
public static NSString RightContext => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
|
||
[Obsolete (Constants.ApiRemovedGeneral)] | ||
[EditorBrowsable (EditorBrowsableState.Never)] | ||
public static NSString SelectedText => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!XAMCORE_5_0
Replaced by #19717 |
No description provided.