Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcode15.1] Bump to Xcode 15.1 Beta 3 #19563

Closed
wants to merge 2 commits into from

Conversation

dalexsoto
Copy link
Member

No description provided.

@dalexsoto dalexsoto changed the title [xcode15.1] Bump PR to Xcode 15.1 Beta 3 [xcode15.1] Bump to Xcode 15.1 Beta 3 Nov 30, 2023
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f6560acb5447f4e0fdb6a30e69f136bfbe20bf92 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: f6560acb5447f4e0fdb6a30e69f136bfbe20bf92 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Comment on lines -2616 to -2622
[NoWatch, NoTV, Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)]
[BaseType (typeof (NEProvider))]
[DisableDefaultCtor]
interface NEFailureHandlerProvider {
[NoWatch, NoTV, Mac (14, 0), iOS (17, 0)]
[Export ("handleFailure:completionHandler:")]
[Async]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes apple. iOS 17 and MacOS 14 and you deprecate this.

Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple deprecating in a .1 release apis from the last release.. the worst part is that it is not a surprise :/

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 32 tests failed, 196 tests passed.

Failures

❌ cecil tests [attempt 4]

1 tests failed, 0 tests passed.
  • Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests [attempt 4]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ introspection tests [attempt 4]

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

❌ monotouch tests [attempt 4]

29 tests failed, 12 tests passed.
  • monotouch-test/Mac [dotnet]/Release [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • monotouch-test/Mac [dotnet]/Release (all optimizations) [dotnet]: Failed (Test run failed.
    Tests run: 2774 Passed: 2686 Inconclusive: 3 Failed: 1 Ignored: 87)
  • monotouch-test/Mac Catalyst [dotnet]/Release (NativeAOT, x64) [dotnet]: Failed (Test run failed.
    Tests run: 2886 Passed: 2756 Inconclusive: 9 Failed: 1 Ignored: 129)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (managed static registrar) [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (managed static registrar, all optimizations) [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (NativeAOT, x64) [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/tvOS - simulator/Debug [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (managed static registrar) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Release (NativeAOT, x64) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f6560acb5447f4e0fdb6a30e69f136bfbe20bf92 [PR build]

Comment on lines +51 to +52
IOS_PACKAGE_VERSION=17.1.1.$(IOS_COMMIT_DISTANCE)
MAC_PACKAGE_VERSION=9.1.1.$(MAC_COMMIT_DISTANCE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

Suggested change
IOS_PACKAGE_VERSION=17.1.1.$(IOS_COMMIT_DISTANCE)
MAC_PACKAGE_VERSION=9.1.1.$(MAC_COMMIT_DISTANCE)
IOS_PACKAGE_VERSION=17.2.0.$(IOS_COMMIT_DISTANCE)
MAC_PACKAGE_VERSION=9.2.0.$(MAC_COMMIT_DISTANCE)

Comment on lines +58 to +68
[Obsolete (Constants.ApiRemovedGeneral)]
[Register ("NEFailureHandlerProvider", SkipRegistration = true)]
public class NEFailureHandlerProvider : NEProvider {
public override NativeHandle ClassHandle => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);

protected NEFailureHandlerProvider (NSObjectFlag t) : base (t) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);
protected internal NEFailureHandlerProvider (NativeHandle handle) : base (handle) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);

public unsafe virtual void HandleFailure (NSError error, Action completionHandler) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);
public unsafe virtual Task HandleFailureAsync (NSError error) => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be !XAMCORE_5_0

Comment on lines +14 to +28
[Obsolete (Constants.ApiRemovedGeneral)]
public unsafe partial class SFAnalysisContextTag {

[Obsolete (Constants.ApiRemovedGeneral)]
[EditorBrowsable (EditorBrowsableState.Never)]
public static NSString LeftContext => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);

[Obsolete (Constants.ApiRemovedGeneral)]
[EditorBrowsable (EditorBrowsableState.Never)]
public static NSString RightContext => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);

[Obsolete (Constants.ApiRemovedGeneral)]
[EditorBrowsable (EditorBrowsableState.Never)]
public static NSString SelectedText => throw new PlatformNotSupportedException (Constants.ApiRemovedGeneral);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!XAMCORE_5_0

@dalexsoto
Copy link
Member Author

Replaced by #19717

@dalexsoto dalexsoto closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants