Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculating the branch name if BRANCH_NAME isn't set. #21115

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix calculating the branch name if BRANCH_NAME isn't set. #21115

merged 2 commits into from
Aug 27, 2024

Conversation

vs-mobiletools-engineering-service2
Copy link
Collaborator

BRANCH_NAME is the variable Jenkins used, so add support for the variable
Azure DevOps uses (BUILD_SOURCEBRANCH).

Backport of #21114

@rolfbjarne
[release/8.0.1xx-xcode15.4] Fix calculating the branch name if BRANCH…
4ee6f1a 
…_NAME isn't set.

BRANCH_NAME is the variable Jenkins used, so add support for the variable
Azure DevOps uses (BUILD_SOURCEBRANCH).
@rolfbjarne rolfbjarne changed the title [main] [release/8.0.1xx-xcode15.4] Fix calculating the branch name if BRANCH_NAME isn't set. Fix calculating the branch name if BRANCH_NAME isn't set. Aug 26, 2024
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
1 similar comment
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: f164cb683c4c6a9c2782ae5d74cc647ddd7a3421 [PR build]

@rolfbjarne rolfbjarne merged commit d304945 into main Aug 27, 2024
49 checks passed
@rolfbjarne rolfbjarne deleted the backport-pr-21114-to-main branch August 27, 2024 08:47
@rolfbjarne
Copy link
Member

/sudo backport release/9.0.1xx-rc1

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Backport Job to branch release/9.0.1xx-rc1 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10114748 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

Assignees
No one assigned
Labels
backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vs-mobiletools-engineering-service2 @rolfbjarne @dalexsoto