Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Ensure files we copy are world-readable. Fix #7395 #7515

Merged
merged 1 commit into from
Dec 2, 2019
Merged

[msbuild] Ensure files we copy are world-readable. Fix #7395 #7515

merged 1 commit into from
Dec 2, 2019

Conversation

spouliot
Copy link
Contributor

Only execute the extra logic when not running on Windows

ref: #7395

@spouliot
[msbuild] Ensure files we copy are world-readable. Fix xamarin#7395
db5886f 
Only execute the extra logic when not running on Windows

ref: xamarin#7395
@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@mauroa mauroa self-requested a review December 2, 2019 17:07
@spouliot spouliot merged commit 0ee2b27 into xamarin:master Dec 2, 2019
@spouliot spouliot deleted the gh7395 branch December 2, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroa mauroa mauroa approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@chamons chamons Awaiting requested review from chamons

@emaf emaf Awaiting requested review from emaf

@jstedfast jstedfast Awaiting requested review from jstedfast

@kzu kzu Awaiting requested review from kzu

@VincentDondain VincentDondain Awaiting requested review from VincentDondain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spouliot @monojenkins @rolfbjarne @mandel-macaque @mauroa