Add ignore_vdis to VM.snapshot method

[benjamreis]

This allow to snapshot a VM and ignore some VDIs during the snapshot
This can lead to a gain of time & space ignoring non essential data

See: #4551

Signed-off-by: BenjiReis [email protected]

[lindig]

Could you confirm that the List.filter logic is correct?

[benjamreis]

Could you confirm that the List.filter logic is correct?

I forgot a not in the condition indeed since I want to exclude all VBDs that are on a VDI present in ignore_vdis

[lindig]

You might want to add tests because we are unlikely to use the new feature and therefore adding tests

[benjamreis]

Yes, I'll look into the XAPi tests and some for this. I'll also link a PR here to our own repo of tests on real XCP-ng hosts.

[benjamreis]

Hi!

Any update on this?
It seems impossible to have optional params in XAPI datamodel object's methods. :/

I'd like to write tests but as long as my PR can't build I can"t.

Thanks.

[benjamreis]

I don't understand the error about pool secret. Can it be mocked?

[benjamreis]

Hi,

Can someone help me initiate a pool secret in my tests? IDK how to do it in a mocked context.

[failure] the pool secrets either do not exist or have not been loaded yet
          Raised at file "stdlib.ml", line 29, characters 17-33
          Called from file "ocaml/xapi/xapi_globs.ml" (inlined), line 46, characters 6-89
          Called from file "ocaml/xapi/helpers.ml", line 448, characters 8-35
          Called from file "ocaml/xapi/xapi_vm_snapshot.ml", line 33, characters 4-98
          Called from file "ocaml/xapi/xapi_vm.ml" (inlined), line 762, characters 2-65
          Called from file "ocaml/tests/test_vm_snapshot.ml", line 25, characters 4-71
          Called from file "src/alcotest-engine/core.ml", line 277, characters 17-23
          Called from file "src/alcotest-engine/monad.ml", line 34, characters 31-35

Thanks

[benjamreis]

I'll let the PR in WIP until I'm done with my manual tests & wrote more tests in our test repo.
I don't think the code will change though so it's good to be reviewed :)

[benjamreis]

Sorry for the ping, I misscliked ^^'.
Is this good for merge?

I re-ran the tests on a host after latest modifcations, test is successful + no XAPI objects leaked. 👍

[lindig]

I think this is good to go. Thanks for going trough the many iterations for something that looked quite simple conceptually.

[benjamreis]

No problem, I learned how XAPI unit tests work which is a good thing for future PR. :)
Thanks for your patience!

[olivierlambert]

Hey @robhoes

I can't find the modification in the generated XAPI doc (should be there https://xapi-project.github.io/xen-api/releases/next.html right?)

Am I missing something?

[psafont]

The API changes weren't properly tracked for some time. Now it's quite better, but not quite enough for this case (parameter versioning is not properly tracked yet)

It should have appeared in https://xapi-project.github.io/xen-api/releases/21.4.0.html