Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize bitmask finding some more. #326

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Optimize bitmask finding some more. #326

merged 1 commit into from
Jan 20, 2024

Conversation

dcherian
Copy link
Collaborator 

| Before [e26fb39e] <main>   | After [9753dfea] <optimize-again>   |   Ratio | Benchmark (Parameter)                                      |
|----------------------------|-------------------------------------|---------|------------------------------------------------------------|
| 4.10±0.05ms                | 3.64±0.04ms                         |    0.89 | cohorts.ERA5MonthHour.time_find_group_cohorts              |
| 4.56±0.05ms                | 4.00±0.06ms                         |    0.88 | cohorts.ERA5MonthHourRechunked.time_find_group_cohorts     |
| 3.31±0.08ms                | 2.79±0.01ms                         |    0.84 | cohorts.ERA5DayOfYear.time_find_group_cohorts              |
| 8.15±0.05ms                | 6.78±0.02ms                         |    0.83 | cohorts.OISST.time_find_group_cohorts                      |
| 659±10μs                   | 519±6μs                             |    0.79 | cohorts.PerfectBlockwiseResampling.time_find_group_cohorts |
| 663±20μs                   | 487±5μs                             |    0.73 | cohorts.PerfectMonthly.time_find_group_cohorts             |
| 2.75±0.03ms                | 1.93±0.03ms                         |    0.7  | cohorts.ERA5Google.time_find_group_cohorts                 |

@dcherian
Optimize bitmask finding some more.
0cccb90 
```
| Before [e26fb39] <main>   | After [9753dfea] <optimize-again>   |   Ratio | Benchmark (Parameter)                                      |
|----------------------------|-------------------------------------|---------|------------------------------------------------------------|
| 4.10±0.05ms                | 3.64±0.04ms                         |    0.89 | cohorts.ERA5MonthHour.time_find_group_cohorts              |
| 4.56±0.05ms                | 4.00±0.06ms                         |    0.88 | cohorts.ERA5MonthHourRechunked.time_find_group_cohorts     |
| 3.31±0.08ms                | 2.79±0.01ms                         |    0.84 | cohorts.ERA5DayOfYear.time_find_group_cohorts              |
| 8.15±0.05ms                | 6.78±0.02ms                         |    0.83 | cohorts.OISST.time_find_group_cohorts                      |
| 659±10μs                   | 519±6μs                             |    0.79 | cohorts.PerfectBlockwiseResampling.time_find_group_cohorts |
| 663±20μs                   | 487±5μs                             |    0.73 | cohorts.PerfectMonthly.time_find_group_cohorts             |
| 2.75±0.03ms                | 1.93±0.03ms                         |    0.7  | cohorts.ERA5Google.time_find_group_cohorts                 |
```
@dcherian dcherian enabled auto-merge (squash) January 20, 2024 21:26
@dcherian dcherian merged commit 3e0653f into main Jan 20, 2024
18 checks passed
@dcherian dcherian deleted the optimize-again branch January 20, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcherian