conftest #159
Merged
conftest #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2020 12:11
|
LGTM. Given that you've gone through tests and are unclear why some exist it's probably enough motivation to drop them. Unless the author of the test says otherwise (apologies if it was me...). Motivated me to refactor May want to check if @bradyrx has any input. Otherwise welcome to merge. |
raybellwaves
approved these changes
Aug 29, 2020
bradyrx
pushed a commit
that referenced
this pull request
Sep 6, 2020
* accessor tests * add conftest.py * PERIODS=10 for effective metrics * probabilistic * rm test_np_deterministic as too close to test_metric_results_accurate * skipna, probabilistic and mark slow * del unnessessary * speedup crps_quad tests * refactor test_metric_results_accurate.py * rm unneccessary dask_bool accessor tests Co-authored-by: Ray Bell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conftest
simplified weights fixture
removed
test_no_deterministicas very close totest_metric_results_accurate.pytest_skipna_functionality: I dont understand the last test, see https://github.com/raybellwaves/xskillscore/issues/79, changed that testwhy do we have
test_skipna_functionality(mostly about time?) andtest_mask_skipna(about lon lat?)?Closes #126
Type of change
Please delete options that are not relevant.
How Has This Been Tested?