Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guards for names max length #64

Closed
exekias opened this issue Aug 25, 2023 · 1 comment · Fixed by #439
Closed

Add guards for names max length #64

exekias opened this issue Aug 25, 2023 · 1 comment · Fixed by #439
Assignees
@ryanslade
Labels
bug Something isn't working

Comments

@exekias
Copy link
Member

exekias commented Aug 25, 2023

names in postgres have a max length of 63 chars by default. We generate names in many places, like:

  • Version schema names
  • Temporary table/column names
  • indices
  • triggers
  • etc

We should make sure we don't generate names longer than the expected max, as that could cause issues down the line.

https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
@exekias exekias added the bug Something isn't working label Aug 25, 2023
@pucke-dev
Copy link
Contributor

I would like to work on this one.

@9bany 9bany mentioned this issue Feb 5, 2024
Closed
4 tasks
@ryanslade ryanslade self-assigned this Oct 28, 2024
@ryanslade ryanslade mentioned this issue Oct 28, 2024
Merged
ryanslade added a commit that referenced this issue Oct 29, 2024
@ryanslade
Validate maximum identifier length (#439)
37a7232 
It should not exceed the maximum of 63.

Closes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanslade ryanslade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate maximum identifier length xataio/pgroll
Max length for naming 9bany/pgroll
3 participants
@ryanslade @exekias @pucke-dev