New command: bootstrap
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Farries <[email protected]>
andrew-farries
approved these changes
Oct 18, 2024
|
|
||
| for _, fileName := range migrationFiles { | ||
| if err := runMigrationFromFile(cmd.Context(), m, fileName, true); err != nil { | ||
| return fmt.Errorf("running migration file '%s': %w", fileName, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("running migration file '%s': %w", fileName, err) | |
| return fmt.Errorf("running migration file %q: %w", fileName, err) |
| file, err := os.Open(fileName) | ||
| if err != nil { | ||
| return fmt.Errorf("opening migration file: %w", err) | ||
| } |
There was a problem hiding this comment.
Now that this is a function I think that file.Close() can be deferred here rather than called later.
andrew-farries
added a commit
that referenced
this pull request
Nov 18, 2024
Add a `pgroll migrate` subcommand. ## Documentation `pgroll migrate` applies all outstanding migrations from a source directory to the target database. Assuming that migrations up to and including migration `40_create_enum_type` from the [example migrations directory](https://github.com/xataio/pgroll/tree/main/examples) have been applied, running: ``` $ pgroll migrate examples/ ``` will apply migrations from `41_add_enum_column` onwards to the target database. If the `--complete` flag is passed to `pgroll migrate` the final migration to be applied will be completed. Otherwise the final migration will be left active (started but not completed). ## Notes: * If no migrations have yet been applied to the target database, `migrate` applies all of the migrations in the source directory. * This PR removes the `pgroll bootstrap` command (#414) as it is equivalent to running `pgroll migrate <directory> --complete` against a fresh database. Part of #446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command called
bootstrap. It runs all the migrations in the specified folder. Migration files are JSON files, ordered alphabetically.Help:
Closes #269