-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creating different index types #417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍
- We should update the documentation with the new index options.
- Consider adding an example migration that shows the new index options and link to it from the docs.
Comment on lines
+230
to
+235
}, | ||
"method": { | ||
"description": "Index method to use for the index: btree, hash, gist, spgist, gin, brin", | ||
"type": "string", | ||
"enum": ["btree", "hash", "gist", "spgist", "gin", "brin"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add some new json schema tests under pkg/jsonschema
to test valid and invalid index types.
andrew-farries
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new options to
create_index
operation:method
: enum for setting different index types. Default:btree
. Available options:btree
,hash
,gist
,spgist
,gin
,brin
.storage_parameters
: optional storage parameters for the index.Example operation to create a new hash index with custom fillfactor:
Furthermore,
analyze
now return the index method under the namemethod
and the definition underdefinition
.Please note that the definition
pgroll
returns is not the SQL statementpgroll
runs when runningcreate_index
migrations.Closes #378