Extract initialisation SQL into separate file #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to edit normally.
ryanslade
commented
Oct 25, 2024
pkg/state/init.sql
Outdated
| @@ -0,0 +1,340 @@ | |||
| CREATE SCHEMA IF NOT EXISTS placeholder; | |||
|
|
|||
| CREATE TABLE IF NOT EXISTS placeholder.migrations | |||
There was a problem hiding this comment.
placeholder will be replaced in code.
ryanslade
commented
Oct 25, 2024
| @@ -411,7 +71,8 @@ func (s *State) Init(ctx context.Context) error { | |||
| } | |||
|
|
|||
| // Perform pgroll state initialization | |||
| _, err = tx.ExecContext(ctx, fmt.Sprintf(sqlInit, pq.QuoteIdentifier(s.schema), pq.QuoteLiteral(s.schema))) | |||
There was a problem hiding this comment.
We weren't using the output of pq.QuoteLiteral
andrew-farries
approved these changes
Oct 28, 2024
I'll see if I can get it to use Prettier |
|
@andrew-farries PTAL |
andrew-farries
approved these changes
Oct 28, 2024
kvch
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to edit normally.
I think we may want to pick a SQL formatter for this which we run automatically too.
It looks like prettier already has a SQL formatter so maybe we can just use that since we already use it to format the json schema.