Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect context cancellation when backing off #437

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Respect context cancellation when backing off #437

merged 5 commits into from
Oct 28, 2024

Conversation

ryanslade
Copy link
Collaborator

No description provided.

@ryanslade ryanslade requested review from exekias and kvch October 28, 2024 10:20
andrew-farries
andrew-farries reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test here, to ensure that that the backfill is aborted on context cancellation when waiting for a lock?

We already have TestWithRetryableTransaction for testing retryable transactions; the new test could be similar to that one.

@ryanslade
Copy link
Collaborator Author

@andrew-farries PTAL

@ryanslade ryanslade merged commit 813b0a1 into main Oct 28, 2024
26 checks passed
@ryanslade ryanslade deleted the rs/backoff-context branch October 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

@exekias exekias Awaiting requested review from exekias

@kvch kvch Awaiting requested review from kvch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanslade @andrew-farries