Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always surround up and down clauses in parentheses #481

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Always surround up and down clauses in parentheses #481

merged 5 commits into from
Nov 22, 2024

Conversation

ryanslade
Copy link
Collaborator

Closes #473

@exekias
Copy link
Member

exekias commented Nov 22, 2024

probably worth updating docs & examples?

andrew-farries
andrew-farries reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. We should update the documentation and example migrations to remove explicit parens as part of this PR too I think.

@ryanslade ryanslade merged commit 929ea27 into main Nov 22, 2024
27 checks passed
@ryanslade ryanslade deleted the rs/up-parenthesis branch November 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries left review comments

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not require parenthesis ( ) in up/down functions
3 participants
@ryanslade @exekias @andrew-farries