Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pgroll sql subcommand #515

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Remove pgroll sql subcommand #515

merged 1 commit into from
Dec 6, 2024

Conversation

andrew-farries
Copy link
Collaborator

The pgroll sql subcommand adds a dependency on the sql2pgroll package which requires cgo due to the pg_query_go dependency.

Remove this subcommand until we're able to cross-compile pgroll with cgo enabled as part of the release process.

The `pgroll sql` subcommand adds a dependency on the `sql2pgroll`
package which requires `cgo` due to the `pg_query_go` dependency.

Remove this subcommand until we're able to cross-compile `pgroll` with
`cgo` enabled as part of the release process.
@andrew-farries andrew-farries marked this pull request as ready for review December 5, 2024 16:19
@andrew-farries andrew-farries merged commit 358c6c6 into main Dec 6, 2024
27 checks passed
@andrew-farries andrew-farries deleted the remove-sql-command branch December 6, 2024 09:25
andrew-farries added a commit that referenced this pull request Dec 7, 2024
andrew-farries added a commit that referenced this pull request Dec 9, 2024
andrew-farries added a commit that referenced this pull request Dec 9, 2024
andrew-farries added a commit that referenced this pull request Dec 10, 2024
andrew-farries added a commit that referenced this pull request Dec 10, 2024
andrew-farries added a commit that referenced this pull request Dec 11, 2024
andrew-farries added a commit that referenced this pull request Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries added a commit that referenced this pull request Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries added a commit that referenced this pull request Dec 11, 2024
andrew-farries added a commit that referenced this pull request Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries added a commit that referenced this pull request Dec 12, 2024
This reverts commit 358c6c6.
andrew-farries added a commit that referenced this pull request Dec 13, 2024
… job (#527)

Make the `release` job run in a `goreleaser/goreleaser-cross` container
so that we can build binaries for all supported architectures.

See the PR description for #525 for
details of why we need a cross-compilation toolchain as a result of
taking a dependency on `pg_query_go` and how the the `goreleaser-cross`
image is used.

The addition of the `-static` `LDFLAG` for the `linux/amd64` and
`linux/arm64` builds is necessary to statically link in order for the
resulting `pgroll` binaries to run in the `FROM scratch` image that
`Goreleaser` uses to build docker images.

Also, revert #515 to re-add the `pgroll sql` command now that `pgroll`
can be built for all platforms when the dependency on `pg_query_go` is
included in the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants