-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pgroll sql
subcommand
#515
Merged
Merged
+0
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pgroll sql` subcommand adds a dependency on the `sql2pgroll` package which requires `cgo` due to the `pg_query_go` dependency. Remove this subcommand until we're able to cross-compile `pgroll` with `cgo` enabled as part of the release process.
exekias
approved these changes
Dec 6, 2024
andrew-farries
added a commit
that referenced
this pull request
Dec 7, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 9, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 9, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 12, 2024
This reverts commit 358c6c6.
andrew-farries
added a commit
that referenced
this pull request
Dec 13, 2024
Loading
Loading status checks…
… job (#527) Make the `release` job run in a `goreleaser/goreleaser-cross` container so that we can build binaries for all supported architectures. See the PR description for #525 for details of why we need a cross-compilation toolchain as a result of taking a dependency on `pg_query_go` and how the the `goreleaser-cross` image is used. The addition of the `-static` `LDFLAG` for the `linux/amd64` and `linux/arm64` builds is necessary to statically link in order for the resulting `pgroll` binaries to run in the `FROM scratch` image that `Goreleaser` uses to build docker images. Also, revert #515 to re-add the `pgroll sql` command now that `pgroll` can be built for all platforms when the dependency on `pg_query_go` is included in the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pgroll sql
subcommand adds a dependency on thesql2pgroll
package which requirescgo
due to thepg_query_go
dependency.Remove this subcommand until we're able to cross-compile
pgroll
withcgo
enabled as part of the release process.