Simplify fetching rows with composite primary keys during backfill #595
+112
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
changed the title
ryanslade
reviewed
Jan 15, 2025
|
LGTM. Won't approve until @andrew-farries has taken a look because auto merge is enabled. |
There was a problem hiding this comment.
Changes look good.
#582 is about a problem with a uuid-valued primary key. To close it with this PR we need a test that uses such a table.
pkg/migrations/backfill.go
Outdated
| @@ -134,13 +134,13 @@ func getIdentityColumns(table *schema.Table) []string { | |||
|
|
|||
| type batcher struct { | |||
| statementBuilder *batchStatementBuilder | |||
| lastValues any | |||
| lastValues []*string | |||
There was a problem hiding this comment.
Can the type of lastValues be just []string. I don't see where we need the pointer type.
Co-authored-by: Ryan Slade <[email protected]>
|
I changed the test table to have UUID primary key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way we put together the
WHEREclause of the query we use to fetch rows during the backfilling process. We no longer check the type of the returned identifiers, instead every literal is quoted as before.I also added a test to check if we can backfilling works properly with composite primary keys.
Closes #582